Fix default value for setting "Auto-hide item methods' documentation" #60346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Some changes occurred in HTML/CSS. |
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Member
|
Thanks! @bors: r+ rollup |
Collaborator
|
📌 Commit b6cfcd3 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
Apr 28, 2019
Fix default value for setting "Auto-hide item methods' documentation" If I open any documentation page in incognito mode (for example [for `Option` enum](https://doc.rust-lang.org/nightly/std/option/enum.Option.html)), then methods will be collapsed, though [on the settings page](https://doc.rust-lang.org/nightly/settings.html) there will be displayed that "Auto-hide item methods' documentation" option is disabled. If I understand correctly, property "Auto-hide item methods' documentation" [should be disabled by default](https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/render.rs#L1969), so correct check would be `property === "true"`. This is consistent with other options: Options which are enabled by default are compared to `"false"` https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/render.rs#L1965-L1968 https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/static/main.js#L2238 https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/static/main.js#L2321 https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/static/main.js#L2070 Options which are disabled by default are compared to `"true"` https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/render.rs#L1970-L1972 https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/static/main.js#L1389 https://github.com/rust-lang/rust/blob/938d4ffe16c4430e1dcede570b06227114cb73d5/src/librustdoc/html/static/main.js#L2334
Collaborator
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I open any documentation page in incognito mode (for example for
Optionenum), then methods will be collapsed, though on the settings page there will be displayed that "Auto-hide item methods' documentation" option is disabled.If I understand correctly, property "Auto-hide item methods' documentation" should be disabled by default, so correct check would be
property === "true". This is consistent with other options:Options which are enabled by default are compared to
"false"rust/src/librustdoc/html/render.rs
Lines 1965 to 1968 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2238 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2321 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2070 in 938d4ff
Options which are disabled by default are compared to
"true"rust/src/librustdoc/html/render.rs
Lines 1970 to 1972 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 1389 in 938d4ff
rust/src/librustdoc/html/static/main.js
Line 2334 in 938d4ff